docs: GUI screenshot rule + headless-run recipe + Send screenshots - #57
Merged
Conversation
Adds a "Visual verification" rule to CLAUDE.md: when an agent touches a deckard-app view, run the app and attach before/after screenshots to the PR (tests alone don't prove a screen renders). - docs/dev/headless-gui-screenshots.md: reproducible recipe to launch the GPUI app headlessly (software Vulkan/llvmpipe + Xvfb), drive it, and capture pixels — including the gpui_linux x11-feature gotcha and the pkill self-kill trap, so future agents don't re-derive them. - docs/screenshots/send-home.png, send-review.png: the two reference shots from the un-gated Send work (PR #54), used as the template the rule points at. Docs only; no code, no dependency changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #54 (Un-gate Send). Establishes a durable convention so GUI changes ship with visual proof, and permanently hosts the Send reference shots.
What this adds
CLAUDE.md→ Visual verification rule: when an agent touches acrates/deckard-appview, run the app and attach before/after screenshots to the PR — tests alone don't prove a screen renders. QA/review flag GUI PRs without screenshots.docs/dev/headless-gui-screenshots.md: a reproducible recipe to bring the GPUI app up in a headless Linux / Claude-on-the-web session (software Vulkan via Mesa llvmpipe + Xvfb), drive it withxdotool, and capture real pixels. Captures the two gotchas that cost the most time so nobody re-derives them:gpui_linux'sx11backend is compiled out by default → startup panicsunreachable; enabling it needs acargo clean -p gpui_linuxto force the recompile (temporary, never committed).pkill -f 'target/debug/deckard'matches your own shell command and kills the session (the mysteriousexit 144).docs/screenshots/send-home.png,send-review.png: the reference shots the rule points at.Docs only — no code, no dependency changes.
The reference shots (captured live via the recipe above)
https://claude.ai/code/session_01VF1DsazbsSL1bHbcz1qzvC
Generated by Claude Code